Skip to content

DOCSP-48326: Connection Pooling technical feedback #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Mar 13, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48326

Staging Links

  • connect/connection-options
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Mar 13, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit f3a2b2e
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67d303f5b03fff00085379bb
    😎 Deploy Preview https://deploy-preview-221--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi requested a review from NoahStapp March 13, 2025 15:57
    @@ -184,7 +184,9 @@ in the {+mdb-server+} manual.
    | **Connection URI Example**: ``maxConnecting=3``

    * - ``maxIdleTimeMS``
    - | The maximum time that a connection can remain idle in the pool.
    - | The maximum time that a connection can remain idle in the pool. When a connection

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    When a connection exceeds the maxIdleTimeMS limit, it is closed and removed from the pool entirely since it's already waiting unused in the pool.

    @mcmorisi mcmorisi requested a review from NoahStapp March 13, 2025 16:12
    @mcmorisi mcmorisi merged commit 9789802 into mongodb:master Mar 13, 2025
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-48326-connection-pool-feedback branch March 13, 2025 16:19
    mcmorisi added a commit that referenced this pull request Mar 13, 2025
    mcmorisi added a commit that referenced this pull request Mar 13, 2025
    mcmorisi added a commit that referenced this pull request Mar 13, 2025
    mcmorisi added a commit that referenced this pull request Mar 13, 2025
    mcmorisi added a commit that referenced this pull request Mar 13, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants